fix large file missing SSE-C key ID #423
Merged
+50
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchan-reef
force-pushed
the
yed/fix-large-file-key-id
branch
from
e8d083f to
6c410f3
Compare
jsuchan-reef
commented
Sep 26, 2023
| new_message = unauthorized.message | ||
| if new_message == '': | ||
| new_message = 'unauthorized' | ||
| new_message = unauthorized.message or 'unauthorized' |
There was a problem hiding this comment.
(unrelated) fix for the following error
File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 462, in _wrap_token
return self._reauthorization_loop(partial_callback)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 486, in _reauthorization_loop
raise self._add_app_key_info_to_unauthorized(e)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/yeef/dev/b2/b2-sdk-python/b2sdk/session.py", line 515, in _add_app_key_info_to_unauthorized
new_message += ' for application key ' + ', '.join(key_messages)
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'
mjurbanski-reef
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes large file missing key ID #422
Key ID included in a header with each uploaded part doesnt suffice, it needs to be passed in
file_infowhen calling.start_large_file().